ephraimbuddy commented on code in PR #24044:
URL: https://github.com/apache/airflow/pull/24044#discussion_r890906874
##########
airflow/www/fab_security/sqla/models.py:
##########
@@ -53,41 +43,11 @@
Identity = None
-def get_sequence_or_identity(sequence_name: str) -> Union[Sequence,
'Identity']:
Review Comment:
`Sequence` is not used in migrations. Some DB(MariaDB) try to add the
sequence at this migration
https://github.com/apache/airflow/blob/2.3.1/airflow/migrations/versions/0073_2_0_0_prefix_dag_permissions.py
but shouldn't. With the sequence in place, creating table directly from ORM,
removes autoincrement default value in postgres. For both ORM and migration to
be the same, this should be removed.
Some discussions:
https://github.com/apache/airflow/issues/24247#issuecomment-1147783514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
