ephraimbuddy commented on code in PR #24044:
URL: https://github.com/apache/airflow/pull/24044#discussion_r895635400
##########
airflow/utils/sqlalchemy.py:
##########
@@ -92,6 +93,13 @@ def process_result_value(self, value, dialect):
return value
+ def load_dialect_impl(self, dialect):
+ if dialect.name == 'mssql':
+ return mssql.DATETIME2(precision=6)
+ elif dialect.name == 'mysql':
+ return mysql.TIMESTAMP(fsp=6)
Review Comment:
Currently, in the migration files, we use `TIMESTAMP` because our use of
dates is from here:
https://github.com/apache/airflow/blob/main/airflow/migrations/db_types.py
which applies the `TIMESTAMP` to the databases. So, we were not really using
`DateTime`s in DB but `TIMESTAMP`, unless we want to change it? Maybe in
another PR because it's going to be a big change as almost all the date columns
uses `TIMESTAMP`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
