Taragolis commented on code in PR #24246:
URL: https://github.com/apache/airflow/pull/24246#discussion_r890961901
##########
airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -151,9 +153,7 @@ def __init__(
self.fargate_pod_execution_role_arn = fargate_pod_execution_role_arn
self.fargate_selectors = fargate_selectors or [{"namespace":
DEFAULT_NAMESPACE_NAME}]
self.create_fargate_profile_kwargs = create_fargate_profile_kwargs or
{}
- self.aws_conn_id = aws_conn_id
- self.region = region
- super().__init__(**kwargs)
+ super().__init__(aws_conn_id=aws_conn_id, region=region, **kwargs)
Review Comment:
For EKS operators `region` use as argument operators I've keep this argument
right now for compatibility just need update docstring
This argument will set to `region_name` class instance attribute, so it
should be fine with templated fields
https://github.com/apache/airflow/blob/60b8227dba97d81bc898f7cf3bf13c9bbfafaa2e/airflow/providers/amazon/aws/operators/aws_base.py#L63-L74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
