ferruzzi commented on code in PR #24246:
URL: https://github.com/apache/airflow/pull/24246#discussion_r891319491
##########
airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -151,9 +153,7 @@ def __init__(
self.fargate_pod_execution_role_arn = fargate_pod_execution_role_arn
self.fargate_selectors = fargate_selectors or [{"namespace":
DEFAULT_NAMESPACE_NAME}]
self.create_fargate_profile_kwargs = create_fargate_profile_kwargs or
{}
- self.aws_conn_id = aws_conn_id
- self.region = region
- super().__init__(**kwargs)
+ super().__init__(aws_conn_id=aws_conn_id, region=region, **kwargs)
Review Comment:
Also, is there a reason to call out `aws_conn_id` and `region_name` in the
new L156? Why not just drop lines 154 and 155 and leave 156 as
`super().__init__(**kwargs)`. If they haven't been pulled out of kwargs, it's
the same thing, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
