uranusjr commented on code in PR #24044:
URL: https://github.com/apache/airflow/pull/24044#discussion_r893302521


##########
airflow/models/serialized_dag.py:
##########
@@ -67,7 +67,7 @@ class SerializedDagModel(Base):
     dag_id = Column(String(ID_LEN), primary_key=True)
     fileloc = Column(String(2000), nullable=False)
     # The max length of fileloc exceeds the limit of indexing.
-    fileloc_hash = Column(BigInteger, nullable=False)
+    fileloc_hash = Column(BigInteger().with_variant(Integer, 'sqlite'), 
nullable=False)

Review Comment:
   I wonder if this is intended (can’t think of a reason) or an oversight 
(seems more likely). The hash shouldn’t use a different integer size…



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to