uranusjr commented on code in PR #24044:
URL: https://github.com/apache/airflow/pull/24044#discussion_r893305606
##########
airflow/models/variable.py:
##########
@@ -47,7 +48,7 @@ class Variable(Base, LoggingMixin):
id = Column(Integer, primary_key=True)
key = Column(String(ID_LEN), unique=True)
- _val = Column('val', Text)
+ _val = Column('val', Text().with_variant(MEDIUMTEXT, 'mysql'))
Review Comment:
Looks like this is done by a case-by-case basis; use `Text` by default, and
change it if that’s not big enough. Let’s keep this as-is then. A later PR to
unify these types (like how we do `StringID` would be a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
