eladkal commented on code in PR #24363: URL: https://github.com/apache/airflow/pull/24363#discussion_r895403244
########## airflow/providers/google/cloud/operators/bigquery.py: ########## @@ -36,7 +36,7 @@ from airflow.models import BaseOperator, BaseOperatorLink from airflow.models.xcom import XCom from airflow.operators.sql import SQLCheckOperator, SQLIntervalCheckOperator, SQLValueCheckOperator -from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob +from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob, _split_tablename Review Comment: I think it's ok. We can use it in the project as we see fit but we basically tell the users don't use the function in custom operators. As for why it's marked private to begin with - I can't tell... I can assume that it's because this is a helper function that takes part in "internal" functionality of operators so the author of the function didn't expect users to use it directly in thier operators. ########## airflow/providers/google/cloud/operators/bigquery.py: ########## @@ -36,7 +36,7 @@ from airflow.models import BaseOperator, BaseOperatorLink from airflow.models.xcom import XCom from airflow.operators.sql import SQLCheckOperator, SQLIntervalCheckOperator, SQLValueCheckOperator -from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob +from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob, _split_tablename Review Comment: I think it's ok. We can use it in the project as we see fit but we basically tell the users don't use the function in custom operators. As for why it's marked private to begin with - I can't tell... I can assume that it's because this is a helper function that takes part in "internal" functionality of operators so the author of the function didn't expect users to use it directly in their operators. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
