ephraimbuddy commented on code in PR #24044:
URL: https://github.com/apache/airflow/pull/24044#discussion_r904672743
##########
airflow/migrations/versions/0112_2_4_0_add_dagwarning_model.py:
##########
@@ -44,7 +44,7 @@ def upgrade():
'dag_warning',
sa.Column('dag_id', StringID(), primary_key=True),
sa.Column('warning_type', sa.String(length=50), primary_key=True),
- sa.Column('message', sa.String(1000), nullable=False),
+ sa.Column('message', sa.Text(), nullable=False),
Review Comment:
@dstandish there's some inconsistency here. In ORM we have `Text` and here
is `String`. I think `Text` will be more appropriate? WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
