dstandish commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r901001809
########## docs/apache-airflow/security/secrets/secrets-backend/index.rst: ########## @@ -101,8 +143,8 @@ Roll your own secrets backend A secrets backend is a subclass of :py:class:`airflow.secrets.BaseSecretsBackend` and must implement either :py:meth:`~airflow.secrets.BaseSecretsBackend.get_connection` or :py:meth:`~airflow.secrets.BaseSecretsBackend.get_conn_value`. -After writing your backend class, provide the fully qualified class name in the ``backend`` key in the ``[secrets]`` -section of ``airflow.cfg``. +After writing your backend class, provide the fully qualified class name in the ``backend`` key or provide Review Comment: right and what i am telling you is that you need to initiate deprecation properly, using the framework we have for this kind of thing. for example see here: https://github.com/apache/airflow/blob/main/airflow/configuration.py#L171 the option for `base_log_folder` was moved from `core` to `logging` -- we don't keep the deprecated values around in the old location. we only keep the new location. and we handle "upgrading" deprecated approaches in AirflowConfigParser. see also methods `_upgrade_auth_backends` and `_upgrade_postgres_metastore_conn`. so it seems to me the right approach is to formally remove it from the config immediately as a deprecation and add the logic to "upgrade" or "convert" the deprecated legacy values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
