dstandish commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r901104423
########## docs/apache-airflow/security/secrets/secrets-backend/index.rst: ########## @@ -101,8 +143,8 @@ Roll your own secrets backend A secrets backend is a subclass of :py:class:`airflow.secrets.BaseSecretsBackend` and must implement either :py:meth:`~airflow.secrets.BaseSecretsBackend.get_connection` or :py:meth:`~airflow.secrets.BaseSecretsBackend.get_conn_value`. -After writing your backend class, provide the fully qualified class name in the ``backend`` key in the ``[secrets]`` -section of ``airflow.cfg``. +After writing your backend class, provide the fully qualified class name in the ``backend`` key or provide Review Comment: I'm not proposing `rewrite entire configurations of Airflow and deprecation model` or `solve all issues of configurations related only to SB`. I'm essentially saying, when you want to change configuration style, you _change_ it; you don't add a _another_ style. I understand that with SB there are complexities with being also able to take "secret" config items from it, and I understand that unfortunately it's a bit chicken egg and confusing and it's not my favorite --- but it's already like that. So maybe this means you can't copy the existing "upgrade" examples exactly -- maybe you have to do something a little different, a little more difficult. But the fundamental principle here is not to "multiply" configuration approaches but to just _change_ the configuration approach, and to maintain backcompat with deprecation warning for a time. I am pretty confident you can do that. But keep in mind, I'm not the boss, right? This is open source. And if you disagree with my thinking, and if no one else is chimes in here, one thing you can always do is start a discussion on the dev list, starting a thread like `[DISCUSS] To add or update secrets backend configuration approach` and you can state your case and see if you find support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
