Taragolis commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r901024555
########## docs/apache-airflow/security/secrets/secrets-backend/index.rst: ########## @@ -101,8 +143,8 @@ Roll your own secrets backend A secrets backend is a subclass of :py:class:`airflow.secrets.BaseSecretsBackend` and must implement either :py:meth:`~airflow.secrets.BaseSecretsBackend.get_connection` or :py:meth:`~airflow.secrets.BaseSecretsBackend.get_conn_value`. -After writing your backend class, provide the fully qualified class name in the ``backend`` key in the ``[secrets]`` -section of ``airflow.cfg``. +After writing your backend class, provide the fully qualified class name in the ``backend`` key or provide Review Comment: There are quite a few findings with use `deprecated_values` and `upgraded_values` for Secrets Backends 1. We need to deprecate in once two configs `[secrets] backend` and `[secrets] backend_kwargs` by `[secrets] backends_config`. I think it is not possible right now. 2. Current and new config expected different types. New JSON List, Current just a string. So warning would be ```airflow/airflow/configuration.py:552: DeprecationWarning: The backend option in [secrets] has been renamed to backends_config - the old setting has been used, but please update your config.``` 3. We want to upgrade config so it should be done before https://github.com/apache/airflow/blob/b692517ce3aafb276e9d23570e9734c30a5f3d1f/airflow/configuration.py#L1601-L1602 4. One side effect about transformation old value to new one, we need to call config.get(section='secrets', key='backends_config') and we don't know where this value stored in `backend` or in `backends_config`. I would rather for now add Depreciation warning in `initialize_secrets_backends()` and after think about how to solve all findings which listed above https://github.com/apache/airflow/blob/68e0741b8cd0554948be4db7946d8c7afaa5b4d0/airflow/configuration.py#L1596-L1600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
