Taragolis commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r901030614
########## docs/apache-airflow/security/secrets/secrets-backend/index.rst: ########## @@ -101,8 +143,8 @@ Roll your own secrets backend A secrets backend is a subclass of :py:class:`airflow.secrets.BaseSecretsBackend` and must implement either :py:meth:`~airflow.secrets.BaseSecretsBackend.get_connection` or :py:meth:`~airflow.secrets.BaseSecretsBackend.get_conn_value`. -After writing your backend class, provide the fully qualified class name in the ``backend`` key in the ``[secrets]`` -section of ``airflow.cfg``. +After writing your backend class, provide the fully qualified class name in the ``backend`` key or provide Review Comment: Secrets Backends itself this is exactly "two ways of doing things" - it initialised outside of configuration and it ignores all validations, most possible for avoid Chicken or the egg. So it is already kind of exception in airflow.configurations The idea of this PR extends current implementation Secrets Backend - make it more flexible, not rewrite entire configurations of Airflow and deprecation model. My current proposal it is focus on implementation of Advanced Secrets Backend rather that try solve all issues of configurations related only to SB. Or you think that this actually blocker? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
