dstandish commented on code in PR #24716:
URL: https://github.com/apache/airflow/pull/24716#discussion_r908960297
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -526,7 +526,7 @@ def build_pod_request_obj(self, context=None):
api_version="v1",
kind="Pod",
metadata=k8s.V1ObjectMeta(
- namespace=self.namespace,
+ namespace=self.namespace or self.hook.get_namespace(),
Review Comment:
yeah this is the only spot right?
https://github.com/apache/airflow/blob/087a944a95998411c9752af25a3c180465ebc9ec/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py#L384
note that i don't actually _set_ namespace....
that line... i'm not sure that using `self.namespace` there is actually
necessary. i am pretty sure `pod.metadata.namespace` will always have a value
since, as we saw from slack i think, it needs one in order to be created. so
probably we could remove that reference to `self.namespace` wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
