potiuk commented on code in PR #24591: URL: https://github.com/apache/airflow/pull/24591#discussion_r909679325
########## airflow/cli/__main__.py: ########## @@ -18,6 +18,7 @@ # under the License. from airflow.cli import airflow_cmd +from airflow.cli.commands import version # noqa: F401 Review Comment: > I like click for witing CLIs, it's nice and easy, but if it doesn't help us get what we actually want for our users (and I'm going to always say we as developers of Airflow should take a bit more pain writing things if it makes their lives better) maybe we shouldn't use it? I am quite there with you @ashb - if we cannot make it "better" (both UI/performance) we should not do it. But if we find a way to make it as performant as what we have today, the UI side of it is great for feature discoverability of the users and make their airflow experience pleasant (again - as long as it does not lag ~ 100 ms or so for auto-complete and command execution - there are some studies that we would need to look at but I think 100ms is around being noticeable ). Colour and nice layout is a great way to communicate things - warning, errors, information etc. (but also it cannot be the only one because of the ~ 8% of color blind males - who are - for better or worse - our main users). This is main reason why we added colours some time ago to logs and I must say as much as I was used to browse logs with just error levels, the colour output make it way more effective in communicating things like warnings or errors (and I realized how important it is since). Also there is one - very, very important aspect - look at the [survey results](https://airflow.apache.org/blog/airflow-survey-2022/#which-interfaces-of-airflow-do-you-use-as-part-of-your-current-role-multiple-choice) the CLI is important to 50% of our users (BTW. I was quite suprised by the almost 100% of the UI). CLI is big part of what the users "see" and experience as Airflow. Using modern, nicely laid out and colorful output has the added benefit of give airflow "modern" look. For met this is also a communication tool with our users "we are fresh and modern" - same reason the "modernized" Airlfow UI make us able to not be classified as "the dinozaurs". I am not say we have to convert to click. I don't even say we should. But I would really love to see if we CAN. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
