ashb commented on code in PR #24591:
URL: https://github.com/apache/airflow/pull/24591#discussion_r910798256


##########
airflow/cli/__main__.py:
##########
@@ -18,6 +18,7 @@
 # under the License.
 
 from airflow.cli import airflow_cmd
+from airflow.cli.commands import version  # noqa: F401

Review Comment:
   I'm all for using click so long as we can get the performance we need. And 
actually, one way of achieving that might be to move more and more code out of 
the `cli/command` files to elsewhere in the API, which has double benefits of 
a) Making the CLI code small so risk of slow imports is greatly reduced, and b) 
makes it easier for the CLI to use an (http) API. (Yes I know that is massive 
feature creep on this original issue, so feel free to ignore this for now)
   
   @uranusjr The docs claim to, but by looking at issues on click the code for 
that doesn't seem to exist.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to