bbovenzi commented on code in PR #24770:
URL: https://github.com/apache/airflow/pull/24770#discussion_r914142822
##########
airflow/www/static/js/dags.js:
##########
@@ -328,24 +325,32 @@ function taskStatsHandler(error, json) {
});
}
-if (encodedDagIds.has('dag_ids')) {
- // dags on page fetch stats
- d3.json(blockedUrl)
- .header('X-CSRFToken', csrfToken)
- .post(encodedDagIds, blockedHandler);
- d3.json(lastDagRunsUrl)
- .header('X-CSRFToken', csrfToken)
- .post(encodedDagIds, lastDagRunsHandler);
- d3.json(dagStatsUrl)
- .header('X-CSRFToken', csrfToken)
- .post(encodedDagIds, dagStatsHandler);
- d3.json(taskStatsUrl)
- .header('X-CSRFToken', csrfToken)
- .post(encodedDagIds, taskStatsHandler);
-} else {
- // no dags, hide the loading dots
- $('.js-loading-task-stats').remove();
- $('.js-loading-dag-stats').remove();
+function refreshDagStats(getDagIds) {
+ if (typeof getDagIds !== 'function') {
+ getDagIds = getAllDagIds;
Review Comment:
As in my comment below, let's remove it if we're not using it. No need for
excess code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
