anselboero opened a new pull request, #641:
URL: https://github.com/apache/airflow-site/pull/641

   Closes Airflow 
[#24963](https://github.com/apache/airflow/issues/24963[](url)) Issue.
   Clicking on the the active menu's arrow will show/hide the submenus.
   
   
![ezgif-4-a4b8168ba4](https://user-images.githubusercontent.com/51990800/180019361-c31e3abf-dce1-4631-91b6-0ea377f40c46.gif)
   
   I noticed that the **globaltoc.html** page is repeated 2 times in the web 
pages.
   
   The first time the HTML code is inserted inside the 
"**content-drawer-wrapper**" div, used to render the sidebar inside the 
"Content" hamburger button, which is shown only when the horizontal screen 
reaches a small width.
   
   ![Screenshot from 2022-07-20 
16-31-53](https://user-images.githubusercontent.com/51990800/180008537-000a8c00-0f9c-4c3f-8219-942c94b69f19.png)
   
   The HTML code of the **globaltoc.html** file is then used to render the 
sidebar which is displayed under normal conditions.
   
   This is why I included the Javascript code in a new file, I wanted to avoid 
it being run twice.
   
   I'm not a front-end expert, but I don't think repeating the same Html and 
Css code twice to make the page responsive is considered a good practice. If 
you agree I could study the Sphinx documentation better and try to refactor the 
**sphinx_airflow_theme**, trying to remove the redundant parts.
   
   Thank you very much for your help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to