anselboero commented on PR #641:
URL: https://github.com/apache/airflow-site/pull/641#issuecomment-1192406011
Thanks a lot Potiuk for your feedback.
Unfortunately there are two points that should be considered before the pull
request can be approved (They have global relevance and are not specific to
this PR, if necessary I can open a new discussion).
- Error: **ESLint couldn't find a configuration file.**
I got this error as the new Js file is located in the
**./sphinx_airflow_theme/sphinx_airflow_theme/static/js** folder but the
configuration file used by Lint is located in the **./landing-pages** folder,
which isn't an ancestor folder for the new Js file: for this reason Lint cannot
check the new Js file.
I tried to add the configuration file in an ancestor folder but this
approach isn't sufficient as it's also necessary to add in the configuration
file's folder the **node_modules** directory, that is at the moment created and
saved by yarn in the landing-pages folder (Otherwise Lint cannot find some
dependencies such as babel-eslint)
Therefore **at the moment I think it is not possible to run Lint on Js
files saved in folders other than ./landing-pages/*.**
- **Add Jquery to the Lint-Js configuration file**
Would it be possible to include the Jquery library among the environments
accepted by Lint or did we decide not to use Jquery to create the site?
(Although sphinx uses it)
Thank you very much and sorry if the comment may seem too long or unclear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
