bluek1te commented on code in PR #24737:
URL: https://github.com/apache/airflow/pull/24737#discussion_r925838572
##########
airflow/providers/hashicorp/hooks/vault.py:
##########
@@ -135,6 +136,9 @@ def __init__(
except ValueError:
raise VaultError(f"The version is not an int: {conn_version}.
")
+ if not client_kwargs:
+ client_kwargs = self.connection.extra_dejson.get("client_kwargs",
{})
Review Comment:
I did some refactoring around this - I changed the name of the kwargs passed
in through the Vault Hook init back to kwargs (I had it as client_kwargs
before), and client_kwargs is now what gets pulled out of connection extra.
client_kwargs gets fused with kwargs as client_kwargs, with kwargs taking
precedence. client_kwargs is what ultimately gets passed to the HVAC client
init.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
