bluek1te commented on code in PR #24737:
URL: https://github.com/apache/airflow/pull/24737#discussion_r925839358
##########
tests/providers/hashicorp/hooks/test_vault.py:
##########
@@ -618,6 +618,33 @@ def test_kubernetes_dejson(self, mock_hvac,
mock_get_connection):
test_client.auth_kubernetes.assert_called_with(role="kube_role",
jwt="data")
test_client.is_authenticated.assert_called_with()
assert 2 == test_hook.vault_client.kv_engine_version
+
+
@mock.patch("airflow.providers.hashicorp.hooks.vault.VaultHook.get_connection")
+
@mock.patch("airflow.providers.hashicorp._internal_client.vault_client.hvac")
+ def test_client_kwargs(self, mock_hvac, mock_get_connection):
+ mock_client = mock.MagicMock()
Review Comment:
I added a summary docstring, I didn't find any other examples in this file
to bounce off of, but if it's not formatted correctly or if you have a link to
a good example of how it should be formatted/written I'll be happy to change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
