potiuk commented on code in PR #25251:
URL: https://github.com/apache/airflow/pull/25251#discussion_r928138702
##########
scripts/ci/docker-compose/local.yml:
##########
@@ -27,12 +27,6 @@ services:
# tests (such as logs)
volumes:
# START automatically generated volumes from VOLUMES_FOR_SELECTED_MOUNTS
in docker_command_utils.py
- - type: bind
Review Comment:
Actually it's quite likely we do not need to use "local" at all for
codespaces. This is only needed for local breeze setup when you want to share
multiple folders with your container. And the main reason it is not the whole
"airflow" folder, is that by mouting whole "source" directory you share all
kinds of artifacts - for example .egginfo files whe you locally run `pip
install -e .` - that often produce various errors when you mount them from
host.
In case of codespaces we ONLY have in-container environment, so we do not
need to worry about and instead of using local.yml we could create a separate
file that would mound whole "airflow" folder (including the .git you mentioned)
.
Actually even better ... we already have such a file :)
* `local-all-sources.yml` is what we should use instead
This file is used by breeze when you specify `breeze --mount-source all`
which is useful in a numebr of situations (mostly when you need the `.git`
folder you mentioned.
So I think better solution will be simply to use `local-all-sources.yml`
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
