potiuk commented on code in PR #25251:
URL: https://github.com/apache/airflow/pull/25251#discussion_r928143394


##########
scripts/ci/docker-compose/local.yml:
##########
@@ -27,12 +27,6 @@ services:
     # tests (such as logs)
     volumes:
       # START automatically generated volumes from VOLUMES_FOR_SELECTED_MOUNTS 
in docker_command_utils.py
-      - type: bind

Review Comment:
   > And we would still have source code in 2 different locations 
`/opt/airflow` & `/workspaces/airflow`. I don't know what to make of that!
   
   No problem whatsoever. There is no performance penalty if the same folders 
are mounted in two places. We actually often do it in breeze, it makes things 
easier.
   
   I do not want to make "/workspaces/folder" influence Airflow's dev env. It's 
the choice made by DevContainers, but from our point of view this is arbitrary 
choice of just one dev env approaches and we should not follow it. If we could 
disable it, it would be great (maybe?) but if not - I am not too worried.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to