potiuk opened a new pull request, #25293: URL: https://github.com/apache/airflow/pull/25293
The legacy Airflow SqlSensor, rejects working wiht comon.sql providers eve if they are perfectly fine to use. While users could switch to the common.sql sensor (and it should work fine). we should not force the users to switch to it. We are implementing "fake" class hierarchy in case the provider is installed on Airflow 2.3 and below. In case of Airflow 2.4+ importing the old DbApiHook will fail, because it will cause a circular import - in such case our new DbApiHook will derive (as it was originally planned) from BaseHook. But In case of Airflow 2.3 and below such import will succeed and we are using the original DbApiHook from airflow.hooks.dbapi as base class - this way any "common.sql" hook on Airflow 2.3 and below will also derive from the airlfow.hooks.dbapi.DbApiHook - thus it will be possible to use it by the original SqlSensor. Fixes: #25274 <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
