potiuk commented on PR #25293: URL: https://github.com/apache/airflow/pull/25293#issuecomment-1195019959
> Maybe instead of importing the deprecated base class, we should do different things depending on Airflow version: > > 1. If running on Airflow < 2.3, import the legacy base class. > 2. In Airflow 2.3+, we add additional logic in `BaseSQLOperator` to also accept hooks inheriting the new base class. > > This would avoid needing the `filterwarning` block, which feels like a hack to me. Yeah. I was wondering if it's not too much of a hack myself. I think we already use version check in a number of places and I agree using it here might be a better idea (I also do not know performance implications of the circular import detection ). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
