ferruzzi commented on code in PR #25413:
URL: https://github.com/apache/airflow/pull/25413#discussion_r936086187
##########
airflow/contrib/operators/ecs_operator.py:
##########
@@ -1,30 +0,0 @@
-#
Review Comment:
> As for your question - in this file you need to support only classes that
existed. We dont add new functionality
I thought I understood this, but the CI is proving me wrong. Before this
CR, contrib looked like this:
```
from airflow.providers.amazon.aws.operators.ecs import ECSOperator,
ECSProtocol
__all__ = ["ECSOperator", "ECSProtocol"]
warnings.warn(
"This module is deprecated. Please use
`airflow.providers.amazon.aws.operators.ecs`.",
DeprecationWarning,
stacklevel=2,
)
```
and `deprecated_classes.py` had this:
```
(
'airflow.providers.amazon.aws.operators.ecs.ECSOperator',
'airflow.contrib.operators.ecs_operator.ECSOperator',
),
```
ECSOperator and ECSProtocol were deprecated some time ago in favor of the
names EcsOperator and EcsProtocol, so it was importing classes which were
deprecated. Do those deprecated classes still have to stay now as well? It
has been a full major release of the provider package so I wanted to start
removing those old methods. In this PR I am now renaming EcsOperator to
EcsRunTaskOperator, and EcsProtocol has been deprecated and moved into
*.hooks.ecs.EcsProtocol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
