pierrejeambrun opened a new pull request, #25610:
URL: https://github.com/apache/airflow/pull/25610

   https://github.com/apache/airflow/pull/25568 added support for retrieving 
mapped instance task logs.
   
   This PR adds support for displaying these logs in the Grid details side 
panel.
   - Mapped Instances rows in the table are not selectable anymore. (Actions 
are done on all of them)
   - Mapped Instances rows are clickable and bring a new details page for 
mapped instances. (We can see the Map Index on top of other detailed 
information).
   - For the new details, logs tab is available and show the logs for this 
particular map index.
   - Breadcrumbs get extended with the map index and the `taskInstance` 
breadcrumbs becomes clickable in this particular case.
   - Extracting tasks actions into its own component.
   - Added a few unit tests.
   
   Tested on:
   - Mapped Tasks (obviously) :heavy_check_mark: 
   - Groups with mapped task :heavy_check_mark: 
   - Logs display, `See More` and `Download` links, and logs filters 
:heavy_check_mark: 
   - When there is multiple pages in the `MappedInstances` Table 
:heavy_check_mark:
   - Breadcrumbs navigation :heavy_check_mark:
   - Task actions for all mapped task are working :heavy_check_mark:
   - Task actions from the details of a mapped task instance does not work with 
the local executor but the calls seems fine. (I didn't modify that part)
   
   _Notes: This adds logic to the `TaskInstance` which is already quite 
complicated. I believe it went from 'complexe' to 'too complexe', but I do not 
see a trivial way to refactor it. I do not want to add a lot of changes on top 
of that PR, I'll most certainly open a follow up PR to this end. Let me know 
what you think about that._
   
   
   
![image](https://user-images.githubusercontent.com/14861206/183465827-bac31210-acf7-49d8-a25e-3ea24d5a2e00.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to