pierrejeambrun commented on code in PR #25610:
URL: https://github.com/apache/airflow/pull/25610#discussion_r942889264
##########
airflow/www/static/js/dag/details/taskInstance/index.tsx:
##########
@@ -54,18 +52,41 @@ const dagId = getMetaValue('dag_id')!;
interface Props {
taskId: Task['id'];
runId: DagRun['runId'];
+ mapIndex: TaskInstanceType['mapIndex'];
+ onSelect: (selectionProps: SelectionProps) => void;
}
-const TaskInstance = ({ taskId, runId }: Props) => {
- const [selectedRows, setSelectedRows] = useState<number[]>([]);
+const TaskInstance = ({
+ taskId, runId, mapIndex, onSelect,
+}: Props) => {
+ const isMapIndexDefined = !(mapIndex === undefined);
+ const selectedRows: number[] = isMapIndexDefined ? [mapIndex] : [];
Review Comment:
SelectedRow is currently used for the task actions. (Empty <=> all mapped,
when non empty only run on those mapIndex).
The name is misleading indeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
