eladkal commented on PR #25700: URL: https://github.com/apache/airflow/pull/25700#issuecomment-1213853265
The optimization of `DAG_DISCOVERY_SAFE_MODE` makes alot of sense. I don't know of a way to write a dag without using the words dag and airflow (due to needed imports). If the issue is that we want also to consider these words in file names then I think It is better to extend the current setting rather than introducing new one. from my experience dag discovery issues are one lf the hardest to figure out for Airflow users (sometimes even experianced ones) this is shared between cluster admins and DAG authors (which are not always the same person in big organizations) I even talk about this exact problem in meetups. By accepting this PR we will even make the problem bigger as it now will involve 2 settings. Reading the discussion thread linked to the PR I didn't see any advantage for adding this setting. The `DAG_DISCOVERY_SAFE_MODE` had a big optimization advantage. What advantage are we getting here? For the moment I'm -1 for this but lets discuss and see... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
