seunggabi commented on PR #25700: URL: https://github.com/apache/airflow/pull/25700#issuecomment-1214136290
@eladkal Thx to your comment. I agree with you, but I think we need to skip_check_name. If we make module extends airflow library(e. g. DefaultDAG) , class extended this default_dag.py dosent have airflow keyword. So, we need to # airflow comment.. It is bad, Thats why we need file or dir name checking, including dag keyword. I suggested including skip_check_name in safe_mode. Because another config value is not good. (Confuse, abuse, many context in the future) It is compatible, because it extend functions. Please give me opinion, have a nice weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
