Taragolis commented on code in PR #25628:
URL: https://github.com/apache/airflow/pull/25628#discussion_r946538472
##########
airflow/providers/amazon/aws/utils/connection_wrapper.py:
##########
@@ -127,13 +139,33 @@ def __post_init__(self, conn: "Connection"):
init_credentials = self._get_credentials(**extra)
self.aws_access_key_id, self.aws_secret_access_key,
self.aws_session_token = init_credentials
- if not self.region_name and "region_name" in extra:
- self.region_name = extra["region_name"]
- self.log.info("Retrieving region_name=%s from %s extra.",
self.region_name, self.conn_repr)
+ if not self.region_name:
+ if "region_name" in extra:
+ self.region_name = extra["region_name"]
+ self.log.info("Retrieving region_name=%s from %s extra.",
self.region_name, self.conn_repr)
+ elif "region_name" in session_kwargs:
+ self.region_name = session_kwargs["region_name"]
+ self.log.info(
+ "Retrieving region_name=%s from %s
extra['session_kwargs'].",
+ self.region_name,
+ self.conn_repr,
+ )
+
+ if not self.verify and "verify" in extra:
+ self.verify = extra["verify"]
+ self.log.debug("Retrieving verify=%s from %s extra.", self.verify,
self.conn_repr)
- if "session_kwargs" in extra:
- self.session_kwargs = extra["session_kwargs"]
- self.log.info("Retrieving session_kwargs=%s from %s extra.",
self.session_kwargs, self.conn_repr)
+ self.profile_name = extra.get("session_kwargs", {}).get("profile_name")
Review Comment:
Seems like I forgot to push last changes to this PR. There is not sense to
get profile by this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
