Taragolis commented on code in PR #25628:
URL: https://github.com/apache/airflow/pull/25628#discussion_r946543810
##########
airflow/providers/amazon/aws/utils/connection_wrapper.py:
##########
@@ -127,13 +139,33 @@ def __post_init__(self, conn: "Connection"):
init_credentials = self._get_credentials(**extra)
self.aws_access_key_id, self.aws_secret_access_key,
self.aws_session_token = init_credentials
- if not self.region_name and "region_name" in extra:
- self.region_name = extra["region_name"]
- self.log.info("Retrieving region_name=%s from %s extra.",
self.region_name, self.conn_repr)
+ if not self.region_name:
+ if "region_name" in extra:
+ self.region_name = extra["region_name"]
+ self.log.info("Retrieving region_name=%s from %s extra.",
self.region_name, self.conn_repr)
Review Comment:
Yeah. I change for a lot of stuff from `DEBUG` to `INFO` severity levels by
previous PR's incidentally.
I will revert mos of them to debug.
##########
airflow/providers/amazon/aws/utils/connection_wrapper.py:
##########
@@ -127,13 +139,33 @@ def __post_init__(self, conn: "Connection"):
init_credentials = self._get_credentials(**extra)
self.aws_access_key_id, self.aws_secret_access_key,
self.aws_session_token = init_credentials
- if not self.region_name and "region_name" in extra:
- self.region_name = extra["region_name"]
- self.log.info("Retrieving region_name=%s from %s extra.",
self.region_name, self.conn_repr)
+ if not self.region_name:
+ if "region_name" in extra:
+ self.region_name = extra["region_name"]
+ self.log.info("Retrieving region_name=%s from %s extra.",
self.region_name, self.conn_repr)
Review Comment:
Yeah. I change for a lot of stuff from `DEBUG` to `INFO` severity levels by
previous PR's incidentally.
I will revert them to debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
