uranusjr commented on code in PR #25788:
URL: https://github.com/apache/airflow/pull/25788#discussion_r949899183
##########
airflow/models/dagrun.py:
##########
@@ -864,29 +861,27 @@ def task_filter(task: "Operator") -> bool:
task_creator = self._get_task_creator(created_counts,
task_instance_mutation_hook, hook_is_noop)
# Create the missing tasks, including mapped tasks
- tasks = self._create_missing_tasks(dag, task_creator, task_filter,
missing_indexes, session=session)
+ tasks = self._create_tasks(dag, task_creator, task_filter,
session=session)
self._create_task_instances(dag.dag_id, tasks, created_counts,
hook_is_noop, session=session)
def _check_for_removed_or_restored_tasks(
self, dag: "DAG", ti_mutation_hook, *, session: Session
- ) -> Tuple[Set[str], Dict["MappedOperator", Sequence[int]]]:
+ ) -> Set[str]:
"""
Check for removed tasks/restored/missing tasks.
:param dag: DAG object corresponding to the dagrun
:param ti_mutation_hook: task_instance_mutation_hook function
:param session: Sqlalchemy ORM Session
- :return: List of task_ids in the dagrun and missing task indexes
+ :return: List of task_ids in the dagrun
Review Comment:
```suggestion
:return: Task IDs in the DAG run
```
This is no longer a list 😛
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
