uranusjr commented on code in PR #23628:
URL: https://github.com/apache/airflow/pull/23628#discussion_r952101263
##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -188,7 +193,7 @@ def execute(self, context: 'Context') -> dict:
)
if response['ResponseMetadata']['HTTPStatusCode'] != 200:
raise AirflowException(f'Sagemaker Processing Job creation failed:
{response}')
- return {'Processing':
self.hook.describe_processing_job(self.config['ProcessingJobName'])}
+ return {'Processing':
serialize(self.hook.describe_processing_job(self.config['ProcessingJobName']))}
Review Comment:
I wonder how viable it is if this function recursively look into the dict
and convert all datetime values into str (essentially
`json.loads(json.dumps(AirflowJsonSerializer))`). Is the dict here generally
pretty large or managable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
