uranusjr commented on code in PR #23628:
URL: https://github.com/apache/airflow/pull/23628#discussion_r953222865
##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -188,7 +193,7 @@ def execute(self, context: 'Context') -> dict:
)
if response['ResponseMetadata']['HTTPStatusCode'] != 200:
raise AirflowException(f'Sagemaker Processing Job creation failed:
{response}')
- return {'Processing':
self.hook.describe_processing_job(self.config['ProcessingJobName'])}
+ return {'Processing':
serialize(self.hook.describe_processing_job(self.config['ProcessingJobName']))}
Review Comment:
I don’t quite understand, why does having multiple datetimes require
recursion? JSON-dumping (with an appropriate serializer) converts all datetimes
to strs, and loading the JSON back to a dict retains those strs and effectively
converts all datetimes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
