RNHTTR commented on PR #25882: URL: https://github.com/apache/airflow/pull/25882#issuecomment-1224617916
I'm not super familiar with the inner workings of KPO, but it mostly looks good at first glance. A couple nits: 1. Should it be something other than `good_name` and `bad_name`? Is this actually an antipattern that the test is testing against, or is good/bad subjective, and something like `existing_name` and `new_name` make sense? 2. Regarding your other point, I think it probably makes more sense to have two separate tests. Maybe use the old one as a template for a new test that has a name like `test_reattach_pod_new_name`? I'm not sure if that name makes sense, but a name that precisely indicates what the test is trying to accomplish. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
