mtilda commented on PR #25882:
URL: https://github.com/apache/airflow/pull/25882#issuecomment-1223492899

   > Can you also add a unit test please?
   
   Happy to! I am playing around with the testing suite for the first time.
   
   I would like to acknowledge a logical flaw in this PR. The name gets mutated 
with a hash string at the end, so we will need to account for that.
   
   If I create a pod like this:
   ```py
   KubernetesPodOperator(
     *args,
     name="example",
     **kwargs,
   )
   ```
   
   The resulting pod name may look like this:
   ```
   example-f19633028ebb49d9b8db3419c38dce6a
   ```
   
   I wonder if the this mutated name is accessible somewhere (need to keep 
digging ⛏), or I can just
   ```
           elif num_pods == 1 and pod.metadata.name.startswith(self.name):
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to