eladkal opened a new pull request, #25930:
URL: https://github.com/apache/airflow/pull/25930

   Related https://github.com/apache/airflow/issues/25669
   **This PR does not change functionality(as requested in the issue) but only 
names.**
   
   Why I think this name change is better?
   
   1. Jira is Atlassian product and its widely known as such. All atlassian 
products are under https://www.atlassian.com/
   
   2.  Unlike the previous case of mailing list discussion [Salesforce <-> 
Tableau](https://lists.apache.org/thread/t9fhhqsdb1x0clg21363s83v27orzk0f) 
issue https://github.com/apache/airflow/issues/13614 here it makes sense to 
unite all under 1 provider:
   
       -  Jira is known to be an Atlassian product. Tableau is not known to be 
a Salesforce product.
       -  There is no specific site for Jira. There is one for Tableau.
       -  Tableau has its own SDK in it's own domain 
[tableauserverclient](https://github.com/tableau/server-client-python)  while 
jira SDK is a module in 
[atlassian-python-api](https://pypi.org/project/atlassian-python-api/)
   
   3.  We will be able to support more Atlassian integration easily without 
need to have a new provider for each one of them. This is mentioned as 
motivation  in https://github.com/apache/airflow/issues/25669
   
   PR info:
   1. No system test changes as jira provider doesn't have any
   2. No doc changes as jira provider doesn't have docs other than auto 
generated ones.
   
   **Things to solve:**
   
   - [ ] static checks will fail on Duplicate integration names found. Not sure 
how to handle this yet.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to