dstandish commented on code in PR #25980:
URL: https://github.com/apache/airflow/pull/25980#discussion_r956456616
##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -352,9 +352,13 @@ def _read_credentials_from_connection(self) ->
Tuple[Optional[str], Optional[str
class AwsGenericHook(BaseHook, Generic[BaseAwsConnection]):
"""
- Interact with AWS.
+ Generic Class for interact with AWS.
Review Comment:
```suggestion
Generic class for interacting with AWS.
```
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -115,7 +115,7 @@ class S3Hook(AwsBaseHook):
"""
conn_type = 's3'
- hook_name = 'Amazon S3'
+ hook_name = 'Amazon S3 (Deprecated)'
Review Comment:
are you deprecating the _hook_ or the _conn type_?
here it looks like you're deprecating the hook?
##########
docs/apache-airflow-providers-amazon/logging/s3-task-handler.rst:
##########
@@ -37,13 +37,16 @@ To enable this feature, ``airflow.cfg`` must be configured
as follows:
# id that provides access to the storage location.
remote_logging = True
remote_base_log_folder = s3://my-bucket/path/to/logs
- remote_log_conn_id = MyS3Conn
+ remote_log_conn_id = aws_s3_conn
# Use server-side encryption for logs stored in S3
encrypt_s3_logs = False
-In the above example, Airflow will try to use ``S3Hook('MyS3Conn')``.
+In the above example, Airflow will try to use
``S3Hook(aws_conn_id='aws_s3_conn')``.
+
+Local test s3 remote logging
+''''''''''''''''''''''''''''
You can also use `LocalStack <https://localstack.cloud/>`_ to emulate Amazon
S3 locally.
To configure it, you must additionally set the endpoint url to point to your
local stack.
-You can do this via the Connection Extra ``host`` field.
-For example, ``{"host": "http://localstack:4572"}``
+You can do this via the Connection Extra ``endpoint_url`` field.
+For example, ``{"endpoint_url": "http://localstack:4572"}``
Review Comment:
what does this change have to do with deprecating the conn type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
