Taragolis commented on code in PR #25980:
URL: https://github.com/apache/airflow/pull/25980#discussion_r956602770
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -115,7 +115,7 @@ class S3Hook(AwsBaseHook):
"""
conn_type = 's3'
- hook_name = 'Amazon S3'
+ hook_name = 'Amazon S3 (Deprecated)'
Review Comment:
I don't think so. Just want to keep same behaviour in the ui so if user
already create connection in the UI before then conn_type would `s3`.
But if change also conn_type I don't think old connection would associate
with S3Hook and can't test connection in UI/API.
The main idea is remove `conn_type` and `hook_name` in the future release
and after that this Connection Type removed from selected list in UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
