Taragolis commented on code in PR #26118:
URL: https://github.com/apache/airflow/pull/26118#discussion_r961093660


##########
airflow/providers/slack/operators/slack.py:
##########
@@ -70,14 +77,9 @@ def construct_api_call_params(self) -> Any:
         )
 
     def execute(self, **kwargs):
-        """
-        The SlackAPIOperator calls will not fail even if the call is not 
unsuccessful.
-        It should not prevent a DAG from completing in success
-        """

Review Comment:
   Actually slack_sdk v3 always validate response and raise an error  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to