Trollgeir commented on a change in pull request #5319:
[AIRFLOW-4564][AIRFLOW-4523][AIRFLOW-4577] Azure Container Instance bugfixes
and improvements
URL: https://github.com/apache/airflow/pull/5319#discussion_r296495187
##########
File path: airflow/contrib/operators/azure_container_instances_operator.py
##########
@@ -208,16 +267,30 @@ def _monitor_logging(self, ci_hook, resource_group,
name):
last_state = None
last_message_logged = None
last_line_logged = None
- for _ in range(43200): # roughly 12 hours
+
+ for _ in range(self.container_timeout):
Review comment:
I initially made it this way to not be dependent on `datetime.now()` beyond
init, as there currently is no way of altering the timeout during execution.
However this is probably an over-optimization and I don't have any objection to
shifting to your suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
