Trollgeir commented on a change in pull request #5319:
[AIRFLOW-4564][AIRFLOW-4523][AIRFLOW-4577] Azure Container Instance bugfixes
and improvements
URL: https://github.com/apache/airflow/pull/5319#discussion_r296679344
##########
File path: airflow/contrib/operators/azure_container_instances_operator.py
##########
@@ -154,16 +204,24 @@ def execute(self, context):
share_name,
account_name,
read_only))
- volume_mounts.append(VolumeMount(mount_name, mount_path,
read_only))
+ volume_mounts.append(VolumeMount(name=mount_name,
+ mount_path=mount_path,
+ read_only=read_only))
exit_code = 1
try:
self.log.info("Starting container group with %.1f cpu %.1f mem",
self.cpu, self.memory_in_gb)
+ gpu_resource = None
+ if self.gpu:
+ gpu_resource = GpuResource(count=self.gpu[0], sku=self.gpu[1])
Review comment:
If we're going to move away from tuples (implying the user has to import
classes), shouldn't we consider using Azure's model object as parameters
instead? Right now we're pretty much just forwarding the parameters into the
Azure model objects. If in the future Azure adds new functionality into their
model object we wouldn't need to upgrade anything on our side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
