dstandish commented on code in PR #25980:
URL: https://github.com/apache/airflow/pull/25980#discussion_r969838773
##########
airflow/providers/amazon/aws/utils/connection_wrapper.py:
##########
@@ -127,9 +127,18 @@ def __post_init__(self, conn: "Connection"):
self.password = conn.password
self.extra_config = deepcopy(conn.extra_dejson)
- if self.conn_type != "aws":
+ if self.conn_type.lower() == "s3":
warnings.warn(
- f"{self.conn_repr} expected connection type 'aws', got
{self.conn_type!r}.",
+ f"{self.conn_repr} has connection type 's3', which is
deprecated. "
+ "Please update your connection and set `conn_type='aws'`.",
Review Comment:
ok, i offered a concrete suggestion. i think the the word "deprecated" is
really the one that has the potential to confuse. it makes it sound like "you
can't use s3 anymore". but really, all we're saying is, s3 connections should
now be stored as aws connections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
