Taragolis commented on PR #26162: URL: https://github.com/apache/airflow/pull/26162#issuecomment-1248021981
> Again - your parallells are not entirely correct - it's not "what code is needed". I agree it is similar code. But IMHO it does not matter. What matters is "who has the incentive to fix it if it is broken", This is fundamental difference. Think "human", "team", "responsibility", "governance" not "code". It depends which way you look. For me it look like the same some additional method added years ago and not well maintained and documented: - IAM auth in Postgres Hook #5223 - Google federation for AWS #12079 The reason why IAM exists in postgres provider and not in amazon as well as google federation in amazon provide and not in google it is clear for me - no other way exists for extend authentication. To be clear I'm agree that auth by IAM from postgres/mysql should move out from postgres provider. I just think about appropriate replacement which might easy to maintain and easy add additional integration with other cloud providers. > Currently, the way to implement different authentications it is through inheritance The issue that right now if you extend hook than you need to also implements all operators. So if we create `AwsPostgresHook` than also need to implement in additional all existed operators and task flow decorators like `AwsPostgresToGCSOperator`. It could be done as well as done for DBApiHook, however DBApiHook not only about auth and also it about support specific protocols for specific database. However for Postgres, Docker, MySQL and might be other it only about how to implements the way how to obtain credentials and pass for specific client. It might be expect execute some class. In this case it might required some changes in core, so it not available in providers until min version of airflow will meet requirements. And right might be it more about create some AIP and discuss with different approaches and benefits, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
