Taragolis commented on PR #26162: URL: https://github.com/apache/airflow/pull/26162#issuecomment-1252307959
@potiuk I think it would required small changes if compare to the current PR. 1. Rename from `BaseDockerCredentialHelper` to something like `BaseDockerRegistryAuth` credential helper might confuse some user - in docker stack already exists utilities with the same name. 2. Move ECR related to amazon provider 3. Assign as Hook parameter rather than `import_string` 4. Some small changes in operator for allow provide this classes But year better have a look after I make changes. I hope it will happen within a couple days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
