Taragolis opened a new pull request, #26452:
URL: https://github.com/apache/airflow/pull/26452
Fundamental refactor of SlackWebhookHook with breaking changes.
I tried to minimise breaking changes, however main (and hope the only once)
braking change SlackWebhookHook not anymore inherit from
`airflow.providers.http.hooks.http.HttpHook` anymore and use
slack_sdk.WebhookClient instead
Additional changes:
1. Warn user that it is not safe to specify webhook token (url) directly in
the Hook and suggest to switch to Airflow Connections.
2. Deprecate specify webhook message attribute in `__init__` method and
mainly use hook attributes only for configure slack_sdk.WebhookClient. It is
still possible to set as Hook arguments.
3. Inform users (always) that it is not possible to change channel, username
and icon by use Slack Incoming Webhook. Users might previously use for two
reasons:
a. Hook and Operators not cover this part
b. Hook initially created for use with Legacy Incoming Webhooks based on
Slack Integration
4. Change SlackWebhookHook arguments in Operators
5. Add documentation for Slack Incoming Webhook connection type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
