Taragolis commented on PR #26452: URL: https://github.com/apache/airflow/pull/26452#issuecomment-1250378777
Even with this PR it is not possible to get rid of `apache-airflow-providers-http` dependency. Mainly because `SlackWebhookOperator` inherit from `SimpleHttpOperator` https://github.com/apache/airflow/blob/706a618014a6f94d5ead0476f26f79d9714bf93d/airflow/providers/slack/operators/slack_webhook.py#L28-L30 But actually it not use any feature of `SimpleHttpOperator` just because it overwrite execute method where all internal stuff of `SimpleHttpOperator` happen. Changes in `SlackWebhookOperator` could be done after this PR. In fact this PR contain a lot of changes so it would be difficult to track changes if it done in single PR. https://github.com/apache/airflow/blob/706a618014a6f94d5ead0476f26f79d9714bf93d/airflow/providers/slack/operators/slack_webhook.py#L94-L110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
