ashb commented on code in PR #26518:
URL: https://github.com/apache/airflow/pull/26518#discussion_r976761807
##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -162,6 +166,9 @@ def _evaluate_trigger_rule(
changed = ti.set_state(State.UPSTREAM_FAILED, session)
elif skipped:
changed = ti.set_state(State.SKIPPED, session)
+ elif removed and successes and ti.map_index > -1:
+ if ti.map_index >= successes:
Review Comment:
Hmm, yes now you mention it this feels like it's going to break in some
other cases.
Like what if there is 1 mapped upstream which is in the failed state, one in
the removed state, this would erroneously remove it I think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
