ephraimbuddy commented on code in PR #26518:
URL: https://github.com/apache/airflow/pull/26518#discussion_r977715064
##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -162,6 +166,9 @@ def _evaluate_trigger_rule(
changed = ti.set_state(State.UPSTREAM_FAILED, session)
elif skipped:
changed = ti.set_state(State.SKIPPED, session)
+ elif removed and successes and ti.map_index > -1:
+ if ti.map_index >= successes:
Review Comment:
Another option is removing this part altogether. It's not part of the
deadlock issue but I feel that it's good to have stuff.
My reason is this:
If at first run upstream was 3 and downstream was 3 too. Upstream created
the downstream. We have 3 -> 3 successes.
Then we reduce upstream to 2, meaning one task is removed and we clear and
rerun the dag, without this part of the change, we will end up running all 3 of
the downstreams: upstream (2 successful, 1 removed). Downstream(3 successful)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
