dstandish commented on code in PR #26509:
URL: https://github.com/apache/airflow/pull/26509#discussion_r977886390
##########
airflow/models/dag.py:
##########
@@ -1189,11 +1195,25 @@ def relative_fileloc(self) -> pathlib.Path:
"""File location of the importable dag 'file' relative to the
configured DAGs folder."""
path = pathlib.Path(self.fileloc)
try:
- return path.relative_to(settings.DAGS_FOLDER)
+ rel_path = path.relative_to(self.dag_processor_dags_folder or
settings.DAGS_FOLDER)
+ if rel_path == pathlib.Path('.'):
+ return path
+ else:
+ return rel_path
except ValueError:
# Not relative to DAGS_FOLDER.
return path
+ @property
+ def dag_processor_dags_folder(self):
Review Comment:
Hmm... that's a good question.... I don't know if it has the same meaning.
Is it correct to assume that processor_subdir will always be the dags folder of
the processor? If so, why didn't they call it dags folder in the first place?
What if there is sometimes an optimization to pass the actual dag file path as
subdir to the dag processor so that it will just load that specific file
instead of all dags in the dags folder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
